OPNsense Forum

Archive => 17.7 Legacy Series => Topic started by: tillsense on November 22, 2017, 06:18:34 pm

Title: [SOLVED] 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: tillsense on November 22, 2017, 06:18:34 pm
Hi Team,

gui works only with "dom.storage.enabled" in the firefox correctly a step back as I think. are there dependencies here?

cheers till
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: franco on November 23, 2017, 07:07:28 am
Hi Till,

I think it's this one: https://github.com/opnsense/core/commit/57e2403 and you can safely revert:

# opnsense-patch 57e2403

It's pretty useful to have "all help" toggle sticky, we also added the same for "advanced" toggle for the next version. But it was not intentional to block anyone from using the GUI with that setting disabled.

Does your JS stop working? What's the error? Did you disable "dom.storage.enabled" in your local install?

Hopefully we can probe these settings for availability before using them, but in any case we need more data points to make an educated decision.


Cheers,
Franco
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: tillsense on November 23, 2017, 06:41:32 pm
Hi Franco,

the help / extended mode I had not tested yet but he is also affected. As a matter of principle, some pages are simply empty. ok here are a few examples for you with "dom.storage.enabled=off in firefox esr":

cheers till

Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: franco on November 23, 2017, 06:58:36 pm
Is that Firefox 57 by any chance?


Cheers,
Franco
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: tillsense on November 27, 2017, 07:41:22 pm
Hi Franco,

no Firefox esr for companies is currently the version 52.5.0esr. The use of DomStorage is more of an implementation question. Which dependencies require this?

cheers till
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: mossi2000 on November 28, 2017, 10:11:46 pm
Is that Firefox 57 by any chance?



Hi Franco,

I'm using FF 57 and opnSense 17.7.8 has no problems in displaying the GUI.

Regards,
  Axel
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: franco on November 30, 2017, 03:18:34 pm
no Firefox esr for companies is currently the version 52.5.0esr. The use of DomStorage is more of an implementation question. Which dependencies require this?

Hi Till,

Let's take a step back and let me ask again two questions:

1. Does reverting this patch fix the issue?

# opnsense-patch 57e2403

2. If the answer to 1. is no, do you run opnsense-devel ? If yes, have you tried opnsense stable release package?

@Axel, thanks for the hint. :)


Cheers,
Franco
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: tillsense on December 01, 2017, 07:01:35 pm
Hi Franco,

yes this patch reverting the issue(feature)  :)

cheers till
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: fabian on December 02, 2017, 06:40:45 pm
I created a patch for this. It can be found here: https://github.com/fabianfrz/core/commit/28b6dff793428b1d0732f658cf2940eb01b24f08
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: franco on December 03, 2017, 08:54:16 am
It's a bit difficult to opnsense-patch this fix. Let us merge that one first -- currently awaiting feedback from Ad. FWIW, it looks like this will do the trick nicely. :)


Cheers,
Franco
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: franco on December 03, 2017, 03:14:12 pm
Hi Till,

Alright, from a clean 17.7.8 you can do this:

# opnsense-patch 8d09e5c5 e45f6108a

If it's not clean, run this beforehand:

# opnsense-revert -r 17.7.8 opnsense


Cheers,
Franco
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: franco on December 07, 2017, 02:58:51 pm
Hi Till,

Should be all better in 17.7.9.


Cheers,
Franco
Title: Re: 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: tillsense on December 12, 2017, 08:07:56 pm
Hi Franco,

oh yes that looks good again! Thanks to all!

cheers till
Title: Re: [SOLVED] 17.7.8 - GUI only with "dom.storage.enabled" correctly e.g. Firefox
Post by: franco on December 12, 2017, 09:27:44 pm
Thanks, marked solved. :)