OPNsense Forum
Archive => 22.1 Legacy Series => Topic started by: muchacha_grande on June 23, 2022, 06:12:43 pm
-
Hi, I have this problem after update. I read that NGINX plugin was updated two.
The error I see in NGINX log is: unknown directive "js_include" in /usr/local/etc/nginx/nginx.conf:41
How can I revert back to the previous NGINX version?
Thank you
EDIT: this was solved on hotfix 22.1.9_1
Thank you again
-
I have the same problem:
unknown directive "js_include" in /usr/local/etc/nginx/nginx.conf:176
How can we fix this?
-
deleted
-
I fixed it reverting nginx to the previous version.
So, the first thing I tried is 'opnsense-revert -r 22.1.8 os-nginx' and it didn't work. Then I tried 'opnsense-revert -r 22.1.8 nginx' and it worked.
So I think that the problem is on this update 'nginx upgraded: 1.20.2_9,2 -> 1.22.0_5,2'.
Looking back in the nginx log I found that the error started to happen in the exact time the nginx package was updated.
May be os-nginx package can be updated preserving the previous nginx package.
I'll try
EDIT: I'm trying os-nginx 1.28 with nginx 1.20.2_9,2 and for now it is working fine. I will pin to this nginx version.
-
Same issue with nginx here. Same error.
-
Thnx!
this opnsense-revert -r 22.1.8 nginx'
fixed it for me also.
W'll wait for the fix for updating nginx again.
-
Ok.. did something fun...
I updated (only) the nginx again to the latest version, and now it keeps working?!
don't know what caused it, hope it works at your end also?
NB. I tested further with stopping nxginx and starting it again, than it is broken again. so reverted back to opnsense-revert -r 22.1.8 nginx'
-
I have the same problem:
unknown directive "js_include" in /usr/local/etc/nginx/nginx.conf:176
How can we fix this?
I have the same problem.
The documentation for module ngx_http_js_module says:
The directive (js_include) was made obsolete in version 0.4.0 and was removed in version 0.7.1. The js_import directive should be used instead.
A simple substitution leads to other errors.
I will wait for this error to be fixed. I hope we don't have to wait.
-
Reverting nginx is the easiest solution for the time being. The plugin wasn't changed in that are, which is good and bad at the same time in this particular case.
Cheers,
Franco
-
From which page can I revert separately Nginx or it it done through the console?
-
Console only.
Cheers,
Franco
-
From which page can I revert separately Nginx or it it done through the console?
I did like this:
# opnsense-revert -r 22.1.8 nginx
-
I think that may be due to the removal of support for the js_include directive.
should use js_import now.
http://nginx.org/en/docs/http/ngx_http_js_module.html#js_import
https://github.com/opnsense/plugins/pull/3016 worked on test vm
-
Great!! I confirm the fix is working fine.
-
Can confirm patch works.
opnsense-patch -c plugins a357676
-
Tried the patch also, but it does not work.
When i Stop Nginx and try to restart it, it fails.
# opnsense-patch -c plugins a357676
Fetched a357676 via https://github.com/opnsense/plugins
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From a357676b926ba9db66bd72c246e9e78bbfaebfaa Mon Sep 17 00:00:00 2001
|From: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
|Date: Sat, 25 Jun 2022 11:42:14 +0300
|Subject: [PATCH] njs0.7.1 compat. (#3016)
|
|---
| www/nginx/src/opnsense/scripts/nginx/ngx_functions.js | 2 ++
| .../src/opnsense/service/templates/OPNsense/Nginx/http.conf | 4 ++--
| 2 files changed, 4 insertions(+), 2 deletions(-)
|
|diff --git a/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js b/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js
|index 5f17d76ee9..3acd7d9dbc 100755
|--- a/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js
|+++ b/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js
--------------------------
Patching file opnsense/scripts/nginx/ngx_functions.js using Plan A...
Hunk #1 succeeded at 47.
Hmm... The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff --git a/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf b/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf
|index 13e5659a99..735bab34d2 100644
|--- a/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf
|+++ b/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf
--------------------------
Patching file opnsense/service/templates/OPNsense/Nginx/http.conf using Plan A...
Hunk #1 succeeded at 21.
done
All patches have been applied successfully. Have a nice day.
patch did run
@XeroX, did you try to stop and restart Nginx after the patch?
NB reverted back to "opnsense-revert -r 22.1.8 os-nginx -> still my nginx is broken and wont start anymore. trying to update it to the latest version again
-
@XeroX, did you try to stop and restart Nginx after the patch?
Nginx was in stopped state while patching and started afterwards.
What does general logs say?
-
reverting back and upgrading and patching all keeps my nginx broken....
i have unknown directive "js_include" in /usr/local/etc/nginx/nginx.conf:176
-
Looks like completely messed up.
Upgrade to latest and apply patch afterwards. Applying patch twice will undo the patch.
-
ok,
did
1. opnsense-revert -r 22.1.8 os-nginx (again now)
2. upgraded nginx to v 1.28 from the opnsense gui
3. run the patch from terminal: opnsense-patch -c plugins a357676
opnsense-patch -c plugins a357676
Found local copy of a357676, skipping fetch.
Hmm... Looks like a unified diff to me...
The text leading up to this was:
--------------------------
|From a357676b926ba9db66bd72c246e9e78bbfaebfaa Mon Sep 17 00:00:00 2001
|From: kulikov-a <36099472+kulikov-a@users.noreply.github.com>
|Date: Sat, 25 Jun 2022 11:42:14 +0300
|Subject: [PATCH] njs0.7.1 compat. (#3016)
|
|---
| www/nginx/src/opnsense/scripts/nginx/ngx_functions.js | 2 ++
| .../src/opnsense/service/templates/OPNsense/Nginx/http.conf | 4 ++--
| 2 files changed, 4 insertions(+), 2 deletions(-)
|
|diff --git a/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js b/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js
|index 5f17d76ee9..3acd7d9dbc 100755
|--- a/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js
|+++ b/www/nginx/src/opnsense/scripts/nginx/ngx_functions.js
--------------------------
Patching file opnsense/scripts/nginx/ngx_functions.js using Plan A...
Hunk #1 succeeded at 47.
Hmm... The next patch looks like a unified diff to me...
The text leading up to this was:
--------------------------
|diff --git a/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf b/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf
|index 13e5659a99..735bab34d2 100644
|--- a/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf
|+++ b/www/nginx/src/opnsense/service/templates/OPNsense/Nginx/http.conf
--------------------------
Patching file opnsense/service/templates/OPNsense/Nginx/http.conf using Plan A...
Hunk #1 succeeded at 21.
done
All patches have been applied successfully. Have a nice day.
did reboot my opnsense box after the patch (did not try to start nginx)
and that fixed it! all is working, did not try to stop and start nginx again now... to glad it is working :-)
XeroX: have you tried stop and start nginx from the opnsense gui?
-
XeroX: have you tried stop and start nginx from the opnsense gui?
Yes, works fine for me.
-
Ok, thanks for testing. I will check it out later also.
-
Same - unknown directive "js_include" in /usr/local/etc/nginx/nginx.conf:118
Tried suggestion twice now. Still not starting.
1. opnsense-revert -r 22.1.8 os-nginx (again now)
2. upgraded nginx to v 1.28 from the opnsense gui
3. run the patch from terminal: opnsense-patch -c plugins a357676
4. reboot
Also tried starting with nginx 1.27 - also won't start. :(
-
Was nginx stopped before those steps?
That was the difference from my earlier testing. And can confirm it is working now, just like XeroX.
hope it will work at your end also.
-
the updated templates need to be applied, so you need to click Apply on SERVICES: NGINX: CONFIGURATION page imho
-
@Fright:
One thing i noticed is that when i stop and start nginx, or apply changes in niginx and go to a website behind nginx i get this error:
MOZILLA_PKIX_ERROR_REQUIRED_TLS_FEATURE_MISSING
When i go to the same webpage again, the error is gone and works.
In ACME Client Certificates - i have [OCSP Must Staple] checked
in NGINX i have [http server] - [OCSP Stapling] checked and [OCSP Verify] checked
Is this a normal error for first time website url visit after a restart or refresh of settings or some error on my end or some bug in nginx?
-
Yes NGINX was stopped after first boot from upgrade. And when trying revert + install + patch.
I did try to apply on NGINX service config - can't remember if it was with reverted or new/patched.
I always get manual full vmware VM backup prior to updating. I just restored back to 22.1.8_1 for now. Revisit in a bit.
-
@RamSense
its a nginx bug feature - "ocsp lazy loading". need to hit every server after nginx restart or use ssl_stapling_file and maintain responses yourself
https://trac.nginx.org/nginx/ticket/1998
-
@RamSense
its a nginx bug feature - "ocsp lazy loading". need to hit every server after nginx restart or use ssl_stapling_file and maintain responses yourself
https://trac.nginx.org/nginx/ticket/1998
Thnx!
-
Upgrade to latest and apply patch afterwards. Applying patch twice will undo the patch.
I confirm everything works!
Thanks for the patch info!
1. opnsense-revert -r 22.1.8 os-nginx (again now)
2. upgraded nginx to v 1.28 from the opnsense gui
3. run the patch from terminal: opnsense-patch -c plugins a357676
-
I had the same issue this morning. Tried to revert, upgrade and patch as suggested but it didn't work.
I commented "js_include" directive in /usr/local/etc/nginx/nginx.conf and nginx finally started (v1.27).
I stay with this temp fix for now, waiting for a patch.
-
Dear all,
I tried the 3 steps and the jsinclude problem went away. But another one came up
BIO_new_file("/usr/local/etc/dh-parameters.4096") failed (SSL: error:02001002:system library:fopen:No such file or directory:fopen('/usr/local/etc/dh-parameters.4096','r') error:2006D080:BIO routines:BIO_new_file:no such file)
Does anyone have a clue? Thanks!
-
Just updated to 22.1.10 and can't start NGINX anymore...
unknown directive "js_include" in /usr/local/etc/nginx/nginx.conf:40
Restoring to older version of NGINX does not help (opnsense-revert -r 22.1.8 nginx):
SyntaxError: Illegal export statement in ngx_functions.js:51, included in /usr/local/etc/nginx/nginx.conf:40
-
Which mirror are you using or are you managing a mirror yourself? It was fixed in a hotfix update.
Cheers,
Franco
-
Which mirror are you using or are you managing a mirror yourself? It was fixed in a hotfix update.
Cheers,
Franco
Hi,
I'm coming from OPNsense 22.1.8_1-amd64 using mirror OPNsense in Amsterdam.
When I check for update I only see 22.1.10, so I skipped 22.1.9 and 22.1.9_1.
Is there a 22.1.10_1?
-
It looks ok to me. What version is your nginx plugin?
-
It looks ok to me. What version is your nginx plugin?
This is what I get (amongst the rest of the packages) when I open the update page:
nginx 1.20.2_9,2 1.22.0_6,2 upgrade OPNsense
-
I mean the plugin os-nginx. Maybe you locked it.
Cheers,
Franco
-
I mean the plugin os-nginx. Maybe you locked it.
Cheers,
Franco
This is now: os-nginx (installed) 1.27 902KiB OPNsense Nginx HTTP server and reverse proxy
You want to know what version it is when I've updated to 22.1.10 again?
If so, I think I can try again this evening.
-
Yes so the latest version is 1.28_1 as you can see from the link:
http://mirror.ams1.nl.leaseweb.net/opnsense/FreeBSD%3A13%3Aamd64/22.1/latest/All/os-nginx-1.28_1.pkg
1.27 definitely doesn't work with the latest nginx software shipped.
-
Yes so the latest version is 1.28_1 as you can see from the link:
http://mirror.ams1.nl.leaseweb.net/opnsense/FreeBSD%3A13%3Aamd64/22.1/latest/All/os-nginx-1.28_1.pkg
1.27 definitely doesn't work with the latest nginx software shipped.
Just updated again 22.1.10
NGINX won't start: os-nginx (installed) 1.28_1 908KiB OPNsense Nginx HTTP server and reverse proxy
same error: unknown directive "js_include" in /usr/local/etc/nginx/nginx.conf:40
-
If you apply your nginx configuration it should work, otherwise it just keeps the old one until reboot.
Cheers,
Franco
-
If you apply your nginx configuration it should work, otherwise it just keeps the old one until reboot.
Cheers,
Franco
Hi,
This is weird, I just loaded my snapshot (I run OPNsense in an ESXi VM) of my last test (faster then updating again from 22.1.8_1) and this time everyting booted and started fine. I could swear I did a reboot yesterday after I discoverd the problem...
-
Solved is solved :)