OPNsense Forum

English Forums => Development and Code Review => Topic started by: oneplane on July 08, 2021, 06:03:41 pm

Title: DHCP Leases improvement
Post by: oneplane on July 08, 2021, 06:03:41 pm

I was looking at the DHCP leases page to see if there was an easy way to improve it to filter and sort (for example on Interface or by IP or by MAC), but it looks like this is one of the pages and services that is still in the legacy format, is that correct?

It looks like it's possible to add some JavaScript in there and tack it on to the old style mixed front-end, but this seems like a prime candidate for a refactoring to Phalcon. Is this something that is already being looked at, or is this, being a core service, not currently something to be messed with.

Title: Re: DHCP Leases improvement
Post by: franco on July 08, 2021, 08:04:21 pm

Hi oneplane,

Correct, but the table header sort was improved for 21.7, see

https://github.com/opnsense/changelog/blob/3056f5bc4a61b902236e34fcde2407d5d1f45dae/community/21.7/21.7.r1#L55

Maybe that's already what you are looking for.

I don't think moving the pages to MVC is the nicest idea at this point in time as they work fine with all the development that went into them lately (especially IPv6).


Cheers,
Franco

Title: Re: DHCP Leases improvement
Post by: oneplane on July 09, 2021, 03:27:32 am

Ah, I see. There is no visual feedback that the header is clickable at all, I guess that's why I assumed it didn't work when I clicked Interface (which is the only one that doesn't do anything).

Title: Re: DHCP Leases improvement
Post by: franco on July 09, 2021, 07:56:26 am

A bit of jQuery magic can probably help here... are you up for the task? :)


Cheers,
Franco