OPNsense Forum

Archive => 20.1 Legacy Series => Topic started by: anomaly0617 on February 10, 2020, 04:36:35 pm

Title: Likely an Easy fix - vpn_ipsec.php phase 1 background color
Post by: anomaly0617 on February 10, 2020, 04:36:35 pm

Hi all,

In the latest release (20.1), there's a hard-coded style element on line 1132 of the output:

Code: [Select]

1129: <style>
1130:  tr.phase1_tr > td {
1131:      font-weight: bolder;
1132:      background-color: #FBFBFB;
1133:  }

Because this is defined after all the css files are rendered, this is breaking themes. For instance, on dark themes (rebellion, tucan) the background is near white and so is the font.

Can this be moved into main.scss or another css file so it can be changed by theme designers?

Thanks!
Anomaly0617

Title: Re: Likely an Easy fix - vpn_ipsec.php phase 1 background color
Post by: anomaly0617 on February 25, 2020, 01:34:17 am

Just wanted to bump this thread in case it was overlooked. I've checked on multiple firewalls (20 or so) and the code is in every one of them that has been upgraded to the 20.x version.

Title: Re: Likely an Easy fix - vpn_ipsec.php phase 1 background color
Post by: AdSchellevis on February 25, 2020, 10:48:07 am

Theme designers should be able to reach the items, but since td inherits from the tr, they likely has to use something like:

Code: [Select]

.phase1_tr > td {
  background-color: #000 !important;
  font-weight: normal !important;
}

We rather don't update the base theme too often (and only at major releases), since this influences non free plugins as well.