OPNsense Forum

English Forums => Development and Code Review => Topic started by: tejas.designer07 on February 11, 2019, 09:49:02 am

Title: [SOLVED] Core package doesn't get packed into the packages sets
Post by: tejas.designer07 on February 11, 2019, 09:49:02 am

Hi,

I created a package from /usr/core

Code: [Select]

cd /usr/core
make package CORE_NAME=myfirewall

package packs everything into myfirewall.txz and stores it into /usr/core/work directory.

I then try to build the iso from /usr/tools.

Code: [Select]

cd /usr/tools
make dvd NAME="MyFirewall"

The package set still doesn't have myfirewall.txz but instead has the original opnsense.txz.

What am I missing? Why doesn't it install my custom core into the package set?

Title: Re: Core package doesn't get packed into the packages sets
Post by: franco on February 11, 2019, 09:56:03 am

When building packages from tools.git, CORE_NAME is read from core.git commits so NAME= does not have the required effect.

Without further logs I cannot help you as you modify files that work by default...


Cheers,
Franco

Title: Re: Core package doesn't get packed into the packages sets
Post by: tejas.designer07 on February 11, 2019, 07:47:47 pm

Thanks for your quick response. Below is the log when I try to build the ISO.

Code: [Select]

>>> Running build step: kernel
>>> Reusing kernel set: /usr/local/opnsense/build/19.1/amd64/sets/kernel-19.1_2-amd64.txz
.MAKE.LEVEL.ENV=MAKELEVEL
ABI_FILE=/usr/lib/crt1.o
BLOCKSIZE=K
CONFIGDIR=/usr/tools/config/19.1
CONFIG_XML=/usr/local/etc/config.xml
COREBRANCH=stable/19.1
COREDIR=/usr/core
COREENV=CORE_PHP=71 CORE_ABI=19.1
CPUS=8
DEBUG=1
DEVICEDIR=/usr/tools/device
EDITOR=vi
ENV_FILTER=env -i USER=root LOGNAME=root HOME=/root SHELL=/bin/csh BLOCKSIZE=K MAIL=/var/mail/root PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin TERM=xterm HOSTTYPE=FreeBSD VENDOR=amd OSTYPE=FreeBSD MACHTYPE=x86_64 PWD=/usr/tools/build GROUP=wheel HOST=OPNsense EDITOR=vi PAGER=more ABI_FILE=/usr/lib/crt1.o
GROUP=wheel
HOME=/root
HOST=OPNsense
HOSTTYPE=FreeBSD
IMAGESDIR=/usr/local/opnsense/build/19.1/amd64/images
LOGNAME=root
LOGSDIR=/usr/local/opnsense/build/19.1/amd64/logs
MACHTYPE=x86_64
MAIL=/var/mail/root
MAKEFLAGS= .MAKE.LEVEL.ENV=MAKELEVEL DEBUG=1
MAKELEVEL=1
META_MODE=normal
OLDPWD=/usr/obj/usr/tools
OSTYPE=FreeBSD
PACKAGESDIR=/.pkg
PAGER=more
PATH=/sbin:/bin:/usr/sbin:/usr/bin:/usr/local/sbin:/usr/local/bin:/root/bin
PLUGINENV=
PLUGINSBRANCH=stable/19.1
PLUGINSDIR=/usr/plugins
PORTSBRANCH=master
PORTSDIR=/usr/ports
PORTSREFBRANCH=master
PORTSREFDIR=/usr/hardenedbsd-ports
PRINT_ENV_SKIP=1
PRODUCT_ADDITIONS=os-dyndns
PRODUCT_ARCH=amd64
PRODUCT_CORE=myfirewall
PRODUCT_CORES=myfirewall myfirewall-devel
PRODUCT_DEVICE=a10
PRODUCT_FLAVOUR=OpenSSL
PRODUCT_GITBASE=https://github.com/opnsense
PRODUCT_HOST=amd64
PRODUCT_KERNEL=SMP
PRODUCT_MIRROR=http://mirror.ams1.nl.leaseweb.net/opnsense
PRODUCT_NAME=MyFirewall
PRODUCT_PERL=5.28
PRODUCT_PHP=71
PRODUCT_PLUGIN=os-*
PRODUCT_PLUGINS=os-*
PRODUCT_PRIVKEY=/usr/tools/config/19.1/repo.key
PRODUCT_PUBKEY=/usr/tools/config/19.1/repo.pub
PRODUCT_PYTHON2=27
PRODUCT_PYTHON3=36
PRODUCT_QUICK=
PRODUCT_RELEASE=MyFirewall-201902111838-OpenSSL
PRODUCT_RUBY=25
PRODUCT_SERVER=user@does.not.exist
PRODUCT_SETTINGS=19.1
PRODUCT_SIGNCHK=/usr/tools/scripts/pkg_fingerprint.sh /usr/tools/config/19.1/repo.pub
PRODUCT_SIGNCMD=/usr/tools/scripts/pkg_sign.sh /usr/tools/config/19.1/repo.pub /usr/tools/config/19.1/repo.key
PRODUCT_SPEED=115200
PRODUCT_SUFFIX=
PRODUCT_TARGET=amd64
PRODUCT_TYPE=myfirewall
PRODUCT_UEFI=yes
PRODUCT_VERSION=201902111838
PWD=/usr/tools/build
SETSDIR=/usr/local/opnsense/build/19.1/amd64/sets
SHELL=/bin/csh
SHLVL=1
SRCBRANCH=stable/19.1
SRCDIR=/usr/src
STAGEDIR=/usr/obj/usr/tools/config/19.1/OpenSSL:amd64
STAGEDIRPREFIX=/usr/obj
TARGETDIR=/usr/local/opnsense/build/19.1/amd64
TARGETDIRPREFIX=/usr/local/opnsense/build
TERM=xterm
TOOLSBRANCH=master
TOOLSDIR=/usr/tools
UPLOADDIR=
USER=root
VENDOR=amd
>>> Running build step: dvd
>>> Running build step: clean
>>> Removing dvd image
>>> Setting up stage in /usr/obj/usr/tools/config/19.1/OpenSSL:amd64
>>> Setting up world in /usr/obj/usr/tools/config/19.1/OpenSSL:amd64/work
>>> Setting up kernel in /usr/obj/usr/tools/config/19.1/OpenSSL:amd64/work
>>> Extracting packages in /usr/obj/usr/tools/config/19.1/OpenSSL:amd64/work
>>> Installing packages in /usr/obj/usr/tools/config/19.1/OpenSSL:amd64/work: os-dyndns myfirewall
Installing pkg-1.10.5_5...
Extracting pkg-1.10.5_5: .......... done
Installing os-dyndns-1.12_1...
Extracting os-dyndns-1.12_1: .......... done
Could not find package: myfirewall
*** Error code 1

Stop.
make: stopped in /usr/tools
Thanks,
Tejas

Title: Re: Core package doesn't get packed into the packages sets
Post by: franco on February 12, 2019, 07:19:01 am

Hi Tejas,

Your custom package has not been added to the tools set.

You can try this:

make clean-core dvd

But I suspect that will fail again because your core.git isn't set up properly. Maybe you have master and stable/19.1 branches reversed. You need to *commit* your modifications to stable/19.1 or set an appropriate branch like COREBRANCH=myownbranch


Cheers,
Franco

Title: Re: Core package doesn't get packed into the packages sets
Post by: tejas.designer07 on February 12, 2019, 09:35:34 pm

Hi Franco,

Thanks :D It worked :D :D

Best,
Tejas