I have attached a pic, is this design optimal from a BGP and redundancy standpoint?
The reason for the switches on the outside of the firewalls is because the ISPs are only giving us a single port on their routers
(https://pasteboard.co/3okFf0mTL9Po.png)
https://pasteboard.co/3okFf0mTL9Po.png
You haven't attached the picture.
But what you are describing is very common :)
We don't know if it is optimal but if your switches are capable enough, this shouldn't have any serious overhead.
I originally put the picture into the message using the image button, but that doesn't show on in the forum, but I reopened, and the text is still there, so I will just copy and paste the link I think that at least will work.