Print Page - nginx: issue is fixed, but fix never made it into OPNsense

Title: nginx: issue is fixed, but fix never made it into OPNsense
Post by: dinguz on March 13, 2025, 10:55:33 AM

I reported the issue here https://forum.opnsense.org/index.php?topic=44880.0 (https://forum.opnsense.org/index.php?topic=44880.0)
Created a github issue as requested: https://github.com/opnsense/core/issues/8176 (https://github.com/opnsense/core/issues/8176)

Now the issue has apparently been fixed in github by kulikov-a, but the fixes never made it into OPNsense.
Could someone have a look at this?

Title: Re: nginx: issue is fixed, but fix never made it into OPNsense
Post by: franco on March 13, 2025, 01:49:15 PM

> The reported issue seems to be fixed by these commits. Can we please have this included in OPNsense?

Not in our repo, someone needs to do a PR...

Title: Re: nginx: issue is fixed, but fix never made it into OPNsense
Post by: dinguz on March 13, 2025, 01:55:49 PM

Unfortunately, I'm not too familiar with GitHub procedures or etiquette. Can I create a PR myself, or is that up to the author of the patch?

Title: Re: nginx: issue is fixed, but fix never made it into OPNsense
Post by: franco on March 13, 2025, 02:24:24 PM

Anyone can, but ideally the author should. A ping on your issue might be enough.

Title: Re: nginx: issue is fixed, but fix never made it into OPNsense
Post by: dinguz on March 31, 2025, 03:30:29 PM

A PR has been made according to Github, but I guess it didn't make it into 25.1.4?

Title: Re: nginx: issue is fixed, but fix never made it into OPNsense
Post by: franco on March 31, 2025, 03:32:23 PM

Yes.

OPNsense Forum

English Forums => 25.1, 25.4 Production Series => Topic started by: dinguz on March 13, 2025, 10:55:33 AM