Hello everyone!
Recently updated to 24.7.12 and it appears that the SFTP upload automation in the AcmeClient is no longer functioning correctly. Relevant error line:
[18-Jan-2025 16:39:36 America/New_York] PHP Fatal error: Uncaught TypeError: OPNsense\AcmeClient\SftpUploader::addContent(): Argument #1 ($content) must be of type string, array given, called in /usr/local/opnsense/scripts/OPNsense/AcmeClient/upload_sftp.php on line 444 and defined in /usr/local/opnsense/mvc/app/library/OPNsense/AcmeClient/SftpUploader.php:99
Stack trace:
#0 /usr/local/opnsense/scripts/OPNsense/AcmeClient/upload_sftp.php(444): OPNsense\AcmeClient\SftpUploader->addContent(Array, '<redacted>', 1737236373, '0440', false)
#1 /usr/local/opnsense/scripts/OPNsense/AcmeClient/upload_sftp.php(282): addFilesToUpload(Array, Object(OPNsense\AcmeClient\SftpUploader))
#2 /usr/local/opnsense/scripts/OPNsense/AcmeClient/upload_sftp.php(234): uploadCertificatesToHost(Array)
#3 /usr/local/opnsense/mvc/app/library/OPNsense/AcmeClient/Utils.php(277): commandUpload(Array)
#4 /usr/local/opnsense/scripts/OPNsense/AcmeClient/upload_sftp.php(566): OPNsense\AcmeClient\Utils::runCLIMain('help', 'getOptionsById', Array, 0, 255)
#5 {main}
thrown in /usr/local/opnsense/mvc/app/library/OPNsense/AcmeClient/SftpUploader.php on line 99
I've verified that the expected certificate files are present on the firewall following a successful cert renewal.
This issue is tracked here: https://github.com/opnsense/plugins/issues/4477