On upgrading I had some errors in the firewall log and traffic issues.
I eventually got it working but was unsure what change I made to resolve it, as I made several changes to bring traffic back online. The errors I saw were:
2024-01-31T15:14:44-05:00 Error firewall There were error(s) loading the rules: pfctl: DIOCADDRULENV: Argument list too long
2024-01-31T15:14:44-05:00 Error firewall /usr/local/etc/rc.filter_configure: The command '/sbin/pfctl -f /tmp/rules.debug.old' returned exit code '1', the output was 'pfctl: DIOCADDRULENV: Argument list too long'
2024-01-31T15:14:44-05:00 Error firewall /usr/local/etc/rc.filter_configure: The command '/sbin/pfctl -Of /tmp/rules.limits' returned exit code '1', the output was 'pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT'
2024-01-31T15:13:34-05:00 Error firewall There were error(s) loading the rules: pfctl: DIOCADDRULENV: Argument list too long
2024-01-31T15:13:34-05:00 Error firewall /usr/local/etc/rc.filter_configure: The command '/sbin/pfctl -f /tmp/rules.debug.old' returned exit code '1', the output was 'pfctl: DIOCADDRULENV: Argument list too long'
2024-01-31T15:13:34-05:00 Error firewall /usr/local/etc/rc.filter_configure: The command '/sbin/pfctl -Of /tmp/rules.limits' returned exit code '1', the output was 'pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT pfctl: DIOCSETTIMEOUT'
2024-01-31T15:12:55-05:00 Error firewall There were error(s) loading the rules: pfctl: DIOCADDRULENV: Argument list too long
Things I did were delete old disabled gateways not in use, cleared several FW rules, cleared several aliases and other changes like this.