OPNsense Forum

English Forums => Development and Code Review => Topic started by: lattera on November 15, 2023, 04:42:01 PM

Title: Patch to fix opnsense/filterlog on FreeBSD/HardenedBSD 14
Post by: lattera on November 15, 2023, 04:42:01 PM
Hey all,

This patch fixes the build of opnsense/filterlog on FreeBSD/HardenedBSD 14: https://git.hardenedbsd.org/hbsdfw/ports/-/commit/7fb1a456593fece1fc0ea4320a34950e55d18ffc

Thanks!
Title: Re: Patch to fix opnsense/filterlog on FreeBSD/HardenedBSD 14
Post by: franco on November 20, 2023, 09:10:36 AM
Hi Shawn,

Hope you are doing good.

I've applied https://github.com/opnsense/ports/commit/f61bebbe9 -- I'm a little confused about the need for static prototypes and the ordering of function declaration and use seems ok. Also code2str() appears to be declared in common.h which is clearly included... if clang 15 still emits errors/warnings it would be good if you could paste them here.

Also pushed the pam_opnsense update https://github.com/opnsense/ports/commit/ac45c6509dc3 since I saw we never repackaged it after your submission. Just ping me on these things. Easy enough to fix. :)


Cheers,
Franco