OPNsense Forum

Archive => 22.7 Legacy Series => Topic started by: ProximusAl on August 23, 2022, 02:18:21 PM

Title: Very Minor Gui Issue
Post by: ProximusAl on August 23, 2022, 02:18:21 PM
Just a tiny little thing my OCD doesn't like seeing.

In the interfaces section of the Dashboard, there is a mismatch in the descriptor of the speed.

1000baseT and 2500Base-T.

From my limited googling, it seems like the latter is correct, so ideally both should read:
1000Base-T and 2500Base-T

As I say, not an issue, but should be a reasonably simple fix to implement.

Title: Re: Very Minor Gui Issue
Post by: franco on August 23, 2022, 02:21:22 PM
Might be a driver issue? We only process the following from ifconfig:

% ifconfig | grep media:
   media: Ethernet autoselect (1000baseT <full-duplex>)
   media: Ethernet autoselect (1000baseT <full-duplex>)
   media: Ethernet autoselect
   media: Ethernet autoselect
   media: Ethernet autoselect
   media: Ethernet autoselect
   media: Ethernet autoselect
   media: Ethernet autoselect (1000baseT <full-duplex>)
   media: Ethernet autoselect (1000baseT <full-duplex>)
   media: Ethernet autoselect (autoselect <full-duplex>)


Cheers,
Franco
Title: Re: Very Minor Gui Issue
Post by: ProximusAl on August 23, 2022, 02:22:47 PM
Looks like you are correct Franco:

# ifconfig | grep media:
        media: Ethernet autoselect (2500Base-T <full-duplex>)
        media: Ethernet autoselect (1000baseT <full-duplex>)
        media: Ethernet autoselect (1000baseT <full-duplex>)
        media: Ethernet autoselect
Title: Re: Very Minor Gui Issue
Post by: franco on August 23, 2022, 02:25:14 PM
FreeBSD source file is https://github.com/opnsense/src/blob/stable/22.7/sys/net/if_media.h#L432

Looks like a historic artefact, but unsure if anyone is crazy enough to edit this for consistency. :)


Cheers,
Franco
Title: Re: Very Minor Gui Issue
Post by: ProximusAl on August 23, 2022, 02:47:46 PM
My OCD is not *that* bad to attempt that :)
Title: Re: Very Minor Gui Issue
Post by: franco on August 23, 2022, 08:53:41 PM
I think we might even use these strings in "Speed and duplex" setting so ifconfig is accepting them as well and nobody will ever be able to touch those... :D


Cheers,
Franco