Hi folks,
I am wondering if 21.1.6 broke Firewall Live Log filtering? The update adds a new template feature but the "+"-button (for adding filter criterias such as "action contains blocks") is not clickable anymore...
Thanks
Beclar
It is clickable for me, but only on the left hand side of the + box. So not broken, but also not 100%
It seems to work fine here using chrome (current release)...I was able to add filters, save a profile, remove a profile, clear filters.
For me, it works but is broken..
I can select a filter "host = 10.0.1.23"
save it as template
When I restore the named template it gives me "dst = 10.0.1.23" instead of "src,dst = 10.0.1.23"
Nice feature and hopefully soon working well.
I wonder if anyone is using Paloalto firewalls? They have very flexible log filtering where you can click anything interesting in the live log and instantly get it added to the "filter bar" a bit like how wireshark filtering works..
For the first report I'll take a look at the add button on Monday but it did work in test ing for sure, because I also worked on the second report here:
https://github.com/opnsense/core/commit/47d6832ed
@Helle: can you try this one?
# opnsense-patch 47d6832ed
Cheers,
Franco
i will try the patch.
And report back
/Anders
Quote from: Greelan on May 29, 2021, 02:34:57 PM
It is clickable for me, but only on the left hand side of the + box. So not broken, but also not 100%
Tried again on Google Chrome (Windows): It works with 90 % zoom factor, where the "+" box is far away from the ">>" box (see attached screenshot "working").
The + box is NOT working on my laptop when the "+" box touches the ">>" box which is on 100 % zoom factor in Google Chrome (see attached screenshot "not_working").
Quote from: Helle on May 29, 2021, 10:55:47 PM
i will try the patch.
And report back
/Anders
Tried the patch and it works fine.
Both saving and recalling, It seems just fine.
Thanks @franco
@beclar2 @Greelan
hi
could you please describe in more details?
any errors in dev console?
@franco
thanks! missed it..
No errors are shown in console :-(
Problem of "dead" + button only occurs when + and >> buttons are touching each other. I tested this with Chrome Windows . On my laptop Chrome´s 100 % zoom stucks the two buttons together which results in the dead + button. See attached screenshot of 100 % zoom - apart from the fact that the buttons are not inline.
If I decrease the browser zoom factor the two buttons are seperated and work without any problem.
Mine does that too WHEN I size my browser window so small those buttons overlap. I'm sure it wasn't tested on a monitor of that size/resolution...or maybe you have a larger text size by default.
hi
can you test?
opnsense-patch -a kulikov-a dac36b4
Thanks
Tried the patch, now I get a scrollbar for the lefthand group of fields/buttons. See the image. This is on my laptop with the browser (Brave) at full screen width, 100% zoom. If I reduce the width of the browser window, then the lefthand group gets less and less visible, with a bigger scrollbar.
Works fine on both computer (2560x1440) and iPad, also get a scroll bar when I size my browser window very small/narrow. What resolution are you running @Greelan?
@Greelan @gpb
I checked more closely and I didn't like my solution. please revert it. I'll try again.
though I should note that I noticed this behavior on 20.7 (before adding templates) - it's a matter of the width of the table inside the bootstrap div.
maybe it's worth setting the width for the third column too - I'll check
opnsense-patch -a kulikov-a 030815a
looks more correct to me. although still not very pretty
Agreed, looks good...not seeing any controls overlapping on resize.
Quote from: Fright on June 01, 2021, 07:23:31 AM
opnsense-patch -a kulikov-a 030815a
looks more correct to me. although still not very pretty
Indeed... with this patch the layout in any zoom factor prevents overlapping and therefore non-functional control buttons. But: on my laptop the >>-Button, the drop down "Choose template" and the trashbin are now three lines (in 100 % view). Nevermind, it seems only a cosmetic problem.
sorry guys
I prepared one more option (moved template controls and reduced the number of divs)
can you try
opnsense-patch -a kulikov-a 2bd7d98
(revert any patches from kulikov-a first)
I think its more decent variant for narrow screens
Thank you very much for your support!
Latest patch gives a nice layout in 100 % view on my little laptop. I noticed some lines that are only on the (old) left part of the controls, but not on the new template controls. See attached screenshot.
@beclar2
thanks for testing !
yes, its filters controls table borders.
it seems to me that they should not be hidden. the border will separate the filter badges from the OR checkbox when you add filters
if the rest of the changes seem convenient then I am ready to make a pr