"opnsense upgraded: 21.1 -> 21.1.3"
- I upgraded it via webgui and ran into the problem.
- To be sure I downloaded the 21.1 DVD iso, bootet, load the current configuration and reinstalled | Problem fix'd.
- Re-ran the update to latest packages & version via webgui again
-> System broken again!
See attachements.
Here is the Title Link of all Widgets Broken
Looks like JavaScript isn't executing. What browser is this and what is the console error?
Cheers,
Franco
As you say JavaScript: Access fixed for me (though it should still be a bug) by switching to Firefox 86.0 portable.
I was using Internet Explorer 11.4046... as I was using Windows Server 2016 to access it.
How do I get the console error? Just watching console for errors?
I don't have such a system but the Internet says the browser console is accessed with "F12".
Cheers,
Franco
ignore... already been reported :D
Quote from: mrkev on March 11, 2021, 05:07:58 PM
ignore... already been reported :D
To make things consistent, it's common to post the link, if already reported somewhere else.
I didn't see that before.
typical IE incompatibility
its on
function upgrade_ui(major = false)
in firmware.volt
ie not support default parameter
and
Object.assign
in views/layouts/default.volt (he throws it for a long time)
also not supported by IE
@Nagilum
if I may, although I'm not a dev and this is easily fixable, but it's really time to think about avoiding using IE for anything other than internal corporate systems. really hard to maintain backward compatibility with IE all the time
It's just what you have 'on hand' when you work on a Server (VM). It still worked with the 21 ISO, so one doesn't expect it to break when doing an update.
If you (intentionally) don't support it anymore, put in a browser switch with a warning, so ppl. at least have an info about (and you might have less tickets). ;-)
As I know that current Firefox is working, I can continue work, but that was unlucky and cost me quite some time to debug (and document to report the problem).
QuoteIf you (intentionally) don't support it anymore, put in a browser switch with a warning, so ppl
no, it's just my 2 cents
quickly ran through the menu and did not notice other errors in IE
I don't mind removing the default parameter from JS. IE 11 is still supported till August so retaining what we had is reasonable.
Cheers,
Franco
Here's the patch https://github.com/opnsense/core/commit/210753253
# opnsense-patch 210753253
Tests welcome. Might be a hotfix candidate if the dashboard situation is being improved anyway.
Cheers,
Franco
If you need to remove a patch, do you still run it a second time?
https://forum.opnsense.org/index.php?topic=4682.msg18201#msg18201
miroco
Yes, still the same.
Cheers,
Franco
Patch works!
I'm overwhelmed from response time and how easy you made it to apply the commit/patch and make one able to test it.
@franco
Then maybe it's worth replacing the
Object.assign
with a
$.extend
in the views/layouts/default.volt so that the translation starts to work for bootgrid on IE? ;)
I can make a pr if you say so
@Nagilum: ok super, I'm adding the patch to the hotfix on Monday just to be safe.
@Fright: sure, sounds great. It might not be added to 21.1.x but 21.7 isn't bad either and people can use manual patching in the meantime if it poses an issue for them.
Cheers,
Franco
@franco
done
Here still no effect. If i click on some dashboard "title" it shows page not found. Firefox 86.0.
@Antaris
different issue
https://forum.opnsense.org/index.php?topic=22026.0
Quote from: Fright on March 13, 2021, 11:02:30 AM
@Antaris
different issue
https://forum.opnsense.org/index.php?topic=22026.0
Thx Fright, with
opnsense-patch 45199e3 title links are fixed. Only traffic graph widget not working in Firefox now. Works on Chrome.
@Antaris
different issue
https://forum.opnsense.org/index.php?topic=21997.0
;)
Thx again. In my situation i have to use:
opnsense-patch 45199e3
opnsense-patch 4053952
opnsense-patch 3274620
In this order to fix the widget titles and trafic graph widget.
I owe you a beer :)
it's all on the first page of the forum)
we all owe devs a beer (or at least coffee) ;)
We will be hotfixing 3 things on Monday (so that would be 21.1.3_3): dashboard widget load, firmware JS compatibility and dashboard title links.
Cheers,
Franco
Hi Franco,
Maybe this https://github.com/opnsense/core/issues/4815 (https://github.com/opnsense/core/issues/4815) too?
Regards, Uwe
Unfortunately not.
Cheers, Uwe