OPNsense Forum
English Forums => Development and Code Review => Topic started by: opnsenseuser on February 20, 2021, 03:22:29 pm
-
soon
-
niiice...
-
cool
can it be TukanDark?)
really like current ver ;)
-
cool
can it be TukanDark?)
really like current ver ;)
I cannot determine that. you would have to ask the guys from opnsense whether they want another theme. The second problem is, I would have to keep 4 themes up to date, which of course would be more work for me.
-
I would have to keep 4 themes up to date, which of course would be more work for me
then one more theme is not worth it anyway
thanks :)
-
I am experimenting. What do you think of that? What do you think of the font?
-
2nd
-
3rd
-
Font in opening post was best imho ;-)
-
Font in opening post was best imho ;-)
Ok, i will Post the next Update soon
-
Ok, i ended up with this
-
and this
-
and this
-
What bugs me with different themes is the (non-existing/not logical) change in color of symbols for firewall rules when changed from enabled to disabled BEFORE pressing "Apply".
-
What bugs me with different themes is the (non-existing/not logical) change in color of symbols for firewall rules when changed from enabled to disabled BEFORE pressing "Apply".
can you show me with a screenshot what you mean exactly?
-
See first attachment, a short list of rules.
Now I disabeled the second (!) rule, and before pressing "Apply" it looks (icon color) as if it is already disabled (attachment 2). With a short list like this it might look like a minor problem, with longer lists and if you want to turn off 2-3 rules it really becomes a problem, especially as after changing the FIRSt rule the "You will have to press APPLY" message changes the screen layout (scrolling down the rules).
-
I think this is a Rebellion-theme Problem. I forwarded this to Martin.
-
I forwarded this to Martin, but his Mailbox is Full. :-(
-
I forwarded this to Martin, but his Mailbox is Full. :-(
:-D
Just test it with your themes, I found it difficult with different themes ;-)
Isn't there a way to kind of "grey-out" rules that are REALLY inactive?
-
I forwarded this to Martin, but his Mailbox is Full. :-(
:-D
Just test it with your themes, I found it difficult with different themes ;-)
Isn't there a way to kind of "grey-out" rules that are REALLY inactive?
can you draw your idea in the picture for me?
The rules which are disabled are in cicada and vicuna yellow. Do you think grey is bettet for a dark theme?
I like to be convinced. every solution that is better is taken.
-
sorry, if I understood @chemlud correctly, he wants the rows with the rules disabled and written to the config to be somehow different from the rows with the rules that were just disabled but not written to the config yet.
may be its possible via:
tr.rule.text-muted {
background-color: darkgray;
}
or some
but it seems to me this will only add unnecessary variegation to the table
Tukan is the most eye-friendly theme imho
that's why I asked not to make the left panel so contrast ;)
-
@opnsenseuser: the "(disabled)" is an option.
Would love to see the option @Fright proposed as a draft... ;-)
-
@opnsenseuser: the "(disabled)" is an option.
Would love to see the option @Fright proposed as a draft... ;-)
Thats a Good idea. But there has to be a Note at the bottom like the rule Icon Description therefore, so everybody knows what that means. And this description has to be done in the Core source.
-
my idea would not have been to mark the entire line but only the words except the first column and the last column because of the icons.
thus an additional note about what the gray line means would also be omitted.
first example is red and second is black (you can make the colors even better visible by choosing another color or a brighter one )
-
strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)
-
strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)
No, it has to be applied first to see this in the rule section.
Disable the nat rules shows the line before applying. so it is a Core sourcecode code thing
-
strike font in red definitely an option. This is the appearance AFTER disaableing, but BEFORE pressing "Apply", correct? :-)
i did a pull request and uploaded a lot of screenshots. i think it looks nice!
https://github.com/opnsense/plugins/pull/2249
-
another wild idea for toggled-not-applied rules: what if we just start to rotate toggle icon? (of course it will work only until you refresh page by applying changes or manually)
no themes updates needed
-
another wild idea for toggled-not-applied rules: what if we just start to rotate toggle icon? (of course it will work only until you refresh page by applying changes or manually)
no themes updates needed
I think your idea is also very good. I've now solved it with crossed out. Let's see how it works when you work with it.
-
something like
https://github.com/kulikov-a/rules/issues/1
-
Thats really really great. should be in the core of opnsense.
-
something like
https://github.com/kulikov-a/rules/issues/1
My first thought was whether I would just make the line more transparent with opacity. But then I abandoned it again because some would think that it was a misrepresentation and then decided to strike out the textline
-
I want to play with this a little more (so that it works with bulk enable/disable, rule order change, retains spin on page change\refresh) and test it well. I will share the result if it is worth it )
But then I abandoned it again because some would think that it was a misrepresentation and then decided to strike out the textline
I agree that here it is not possible to do so much with the styles only (eg it will be seen that the rule has been changed, but it will not be clear what exactly) - there is not enough data in the html. need to work with the script imho.