OPNsense Forum

Archive => 20.7 Legacy Series => Topic started by: tofaz on November 10, 2020, 05:16:30 PM

Title: Dashboard: CPU usage graph style
Post by: tofaz on November 10, 2020, 05:16:30 PM
Hi all,

this is mainly a personal/cosmetic taste and I just wanted to know what do you think about changing the CPU usage graph in the dashboard to be the same as the one for State table size/MBUF Usage/Memory usage/Disk usage?

Beside being the same style I think the bars provide more detailed view, always showing the percentage value of the usage.

Thank you,
tofaz
Title: Re: Dashboard: CPU usage graph style
Post by: tofaz on November 23, 2020, 06:22:17 AM
up
Title: Re: Dashboard: CPU usage graph style
Post by: Ricardo on November 23, 2020, 11:03:29 AM
Open feature request here: https://github.com/opnsense/core/issues
otherwise very low probability it will be even responded to (even if you open feature request, that means 0 guarantee, and your request remains low popularity, set your expectations accordingly, don't expect resolution in 2-3 years, yes years)
Title: Re: Dashboard: CPU usage graph style
Post by: Fright on November 23, 2020, 02:32:36 PM
@Ricardo
I think it can be faster. Make changes in widget php and PR )
@tofaz
imho chart makes sense: it shows some history of cpu load.
may be better to add a progress bar. and leave the chart as is?
Title: Re: Dashboard: CPU usage graph style
Post by: Fright on November 23, 2020, 04:00:44 PM
something like this?
It makes sense?
Title: Re: Dashboard: CPU usage graph style
Post by: tofaz on November 23, 2020, 05:38:12 PM
This looks good to me! In my personal case if I need more historical CPU data I would go straight to the CPU usage graph, otherwise I just need the current snapshot once I'm on the dashboard.

My post aimed to gather opinions from users/devs prior to post a PR as it's not really a "must" change.
Title: Re: Dashboard: CPU usage graph style
Post by: Fright on November 23, 2020, 05:58:55 PM
these are very simple changes (only 10 lines in one file), so all that remains is to convince the devs of the benefits of this.
for me as a user, this does not add much benefit, but it does not bother me either.
I can attach a widget php-file if you want to use the forum link in your FR (if you will)
Title: Re: Dashboard: CPU usage graph style
Post by: tofaz on November 23, 2020, 08:49:55 PM
That would be great! Thank you very much!
Title: Re: Dashboard: CPU usage graph style
Post by: Fright on November 24, 2020, 06:07:38 AM
just one question. maybe this one? even less code, no extra progress-bar, there is already room for these at chart name column
widget file attached (added strings 49,50; string 190 modified)
--
version with progress-bar attached to the post with progress-bar image
(strings added: 49-52;215-223)
Title: Re: Dashboard: CPU usage graph style
Post by: tofaz on November 24, 2020, 05:16:18 PM
The progress bar is the one appealing to me. But not sure about other users.
Title: Re: Dashboard: CPU usage graph style
Post by: tofaz on November 24, 2020, 08:54:43 PM
Feature request created: https://github.com/opnsense/core/issues/4480

Thank you Fright for your effort/help!
Title: Re: Dashboard: CPU usage graph style
Post by: Fright on November 25, 2020, 03:48:14 PM
@AdSchellevis has already added changes!
can wait for release or apply patch
opnsense-patch 235ef7f