OPNsense Forum

English Forums => General Discussion => Topic started by: rfanch3r on May 07, 2020, 05:40:10 AM

Title: Thermal Sensors - Change to fahrenheit
Post by: rfanch3r on May 07, 2020, 05:40:10 AM
Is there some way to change this to fahrenheit, is there some official request I need to submit if not?
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: bartjsmit on May 07, 2020, 09:45:39 AM
You mean like this? https://xkcd.com/2292/  ;D

Bart...
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: rfanch3r on May 07, 2020, 02:32:44 PM
Not helpful? I cant tell if you are joking or serious. Not everyone abides by Celsius temps.
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: chemlud on May 07, 2020, 03:32:24 PM
The world has adapted the SI-scales for good reason.

https://en.wikipedia.org/wiki/International_System_of_Units

Cope with it...
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: franco on May 07, 2020, 04:33:17 PM
It should be easy to patch it before display (the OS gives Celsius), but the larger challenge is building a setting for it and placing it appropriately.


Cheers,
Franco
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: rfanch3r on May 08, 2020, 12:08:35 AM
@chemlud, no they haven't and I will not.

@franco, looks like I am the "only one" that wants this, where would I need to look to add this myself? pfsense had this option so it shouldn't be that hard, I would think. To be clear I do not want a perm change, just a flag to switch it on/off.
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: marjohn56 on May 08, 2020, 11:07:03 PM
its pretty easy to do this, you just want the cpu temps in that old fashioned format yes?  ::)




I'll post a PR for this next week.
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: rfanch3r on May 08, 2020, 11:47:03 PM
lol, not sure what the old fashion sense is referring to but yes, just something where there is a tick to display it in a format where it makes sense to me. Old fashion or not. I am more than happy to make the change myself, I just need to know what to do and where to add it.
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: marjohn56 on May 09, 2020, 08:59:49 AM
Is done.


https://github.com/opnsense/core/pull/4098 (https://github.com/opnsense/core/pull/4098)
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: rfanch3r on May 10, 2020, 09:49:52 AM
@marjohn56 Thanks so much for the quick turn around. Could you add in something to round off all of the 0's that show up?

Currently showing on my last 2 cores 116.60000000000001 °F then switches to 118.4 so on and so on.
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: marjohn56 on May 10, 2020, 10:16:35 AM
Yes will do.
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: marjohn56 on May 10, 2020, 11:21:13 AM
Is done..
Title: Re: Thermal Sensors - Change to fahrenheit
Post by: rfanch3r on May 11, 2020, 12:27:38 PM
For our colonial cousins - LOL