OPNsense Forum
English Forums => Development and Code Review => Topic started by: MasterXBKC on January 03, 2018, 08:04:26 pm
-
I have a plugin that is pretty much done, but i need some assistance in finishing its packing, testing, and getting it published so that it appears on opnsenses plugin list for easy installation.
i estimate that it should only take 3-5 hours at maximum to get this up and running, and i am looking for the person to help with this.
You need to have at least basic to moderate PHP skills, understand opnsenses cron implementation, and have a strong understanding of the git/package/plugin system in opnsense.
Whos interested?
-
Is this a commercial plugin or open source
-
It would be for commercial use.
-
Is this a commercial plugin or open source
The plugin itself is already built, i just need help with packaging and publishing, and testing, if that was not clear, it already functions if you put the files onto a device manually. but i want to make it easily install-able.
-
If you follow the guides you should be able to create a pkg.
Do you want to sell the binary or does it work with a license ID?
-
There is no need to sell the binary, or have the code do any licensing functions itself.
This plugin would simply be a connector that connects the firewall to my central management system, which handles all the licensing internally. The plugin doesnt have any configuration options on the firewall side, that too is all controlled on the central system.
-
Then you should just open a PR or send Franco a PM
-
I am aware and have helped for free in the past. :)
Currently the effort focuses on getting 18.1 out the door... and a lot of other things will have to wait including this.
The recent CPU exploits amongst others at my day job do not make this less difficult to balance at the moment.
Cheers,
Franco
-
I dont see any reason why not pushing a PR and talk about on github since the source will be open anyway
-
I dont see any reason why not pushing a PR and talk about on github since the source will be open anyway
PR?
-
"Pull request" on GitHub.
The thing is this: there needs to be made a decision with regard to commercially-driven plugins in the upstream repo and what that even entails so that it's clear to follow this baseline.
All the tools are available to run a secondary repository so one doesn't have to open-source plugins. Crossing this over backwards may be interpreted as a stretch too far.
For now an internal core team discussion has not happened. A community discussion neither. So, what do you guys think where the line may be?
Cheers,
Franco
-
Hm, but when ZeroTier would offer their service only for money .. wouldn't this be the same?
I'm open to anything ..
-
If we are the main source of advertising for a service it could create a conflict of interest. Any plugin published will be propagated to thousands of users. And for that reason we also have to make sure the service is secure, the plugin doesn't leak data, how useful is it if you don't pay for it, etc.
Cheers,
Franco
-
Hm, but when ZeroTier would offer their service only for money .. wouldn't this be the same?
I'm open to anything ..
So zerotier is a VPN, ethernet bridge, etc, this is nothing like my system, PFMonitor is for basic remote management, threat alerting, threat analytics, and monitoring of the firewalls.
-
If we are the main source of advertising for a service it could create a conflict of interest. Any plugin published will be propagated to thousands of users. And for that reason we also have to make sure the service is secure, the plugin doesn't leak data, how useful is it if you don't pay for it, etc.
Cheers,
Franco
I would have no issue making a free basic tier, or 60 day trial type arrangement, Hell even a even free or 50-75% discounted prices for schools/non-profits, etc. Im not a conglomerate out to cash in on the open source community here.
I could even do a crediting system to help boost opnsense/deciso by granting a 6 month full license for anyone who purchased from Deciso, thus promoting them, and making buyers want to go thru deciso so they get the free license.
Im trying to make this as sweet a deal as i can without breaking my own bank.
I'll even put quick links inside the PFMonitor central control panel to order more devices from Deciso.
A free tier could include basic management, a week of config backups, the monitoring dashboards, essentially everything except the threat monitoring and analytics, and limited backup capacity.
If i knew how to setup a secondary repo, and get the plugin listed inside opnsense myself i would have already, but im being realistic in that i know i can find someone who does know how a lot quicker, who can also make sure its done right the first time so i am not stumbling through it carrying a knife so to say.
As far as the security aspects, OPNSense peeps only need to ask to see how secure it is, i obviously dont want to provide a copy of the source-code publicly, but for examination i would be happy to share screens, etc.
-
Also, on the security front.
My platform does not require any open ports like a traditional web api does. My plugin connects out to my central system from each firewall, so there is not exposed api on the firewalls to be scanned, brute forced, etc.
The firewalls checkin every 60 seconds, and ask for any scheduled tasks, commands, etc, runs them, syncs its vital signs, and then repeats. Rather than using timers, ive utilized cron, allowing the checkin program to terminate when its work is done, and then be re-run at the next minute. I use pre-defined functions inside the checkin agent, rather than have raw api/shell commands crossing back and fourth to potentially be exploited somehow, this allows direct control of what can, and cannot be commanded of the checkin agent. It also communicates using TLS.