OPNsense Forum

English Forums => 23.7 Legacy Series => Topic started by: opnfwb on September 14, 2023, 06:46:17 pm

Title: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: opnfwb on September 14, 2023, 06:46:17 pm
Greetings! I'm noticing a small issue where I cannot use the search function when viewing the Firewall/Diagnostics/States. Any search I run in the firewall states diagnostic view always returns with "no results"
Title: Re: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: Monviech on September 14, 2023, 07:12:16 pm
I just tested it too and it only shows results when I type full IPv4 or IPv6 addresses. It doesn't show results when there's just partially written ones.

It happens in sessions and in states.

I just tested it on an older version (OPNsense 23.4.2-amd64) too and there partial strings work.
Title: Re: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: franco on September 14, 2023, 07:23:11 pm
If I recall correctly that change was in 23.7.3?
Title: Re: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: opnfwb on September 14, 2023, 07:53:07 pm
Franco you're right. I fired up another VM that still has 23.7.3 on it and I see the same thing.

However, if this is an intentional change I have to admit I much preferred the "old" way of the partial matches. I used to be able to search by keyword of my firewall rule name.
Title: Re: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: franco on September 14, 2023, 08:35:22 pm
It was these two:

https://github.com/opnsense/core/commit/6487512
https://github.com/opnsense/core/commit/3322a2e

# opnsense-patch 6487512 3322a2e

The idea was to search for split terms, but maybe the boundary matching is handled wrongly now.


Cheers,
Franco
Title: Re: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: opnfwb on September 15, 2023, 03:37:08 pm
Thanks Franco, those patches worked.  8)
Title: Re: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: opnfwb on February 16, 2024, 09:17:54 pm
For me I'm still seeing the same behavior after upgrading and am unsure if I can apply these patches on the newer 24.1.x series?

Is this the new intended behavior to not match partial searches in the Firewall Sessions or States view?

Thanks for your time and apologies if I'm being a "squeaky wheel" on this. But I really liked that feature and I miss it. :)
Title: Re: Firewall Diagnostic States not searchable after 23.7.4 upgrade
Post by: AdSchellevis on February 17, 2024, 09:53:51 am
Maybe better open a ticket (https://github.com/opnsense/core) using our bug report template, it's intentional to search for addresses/networks (e.g. 192.168.1.1, 192.168.0.0/24) when offered, I'm doubting about the text parts in the search phrase.

Best regards,

Ad